After all this time, and finally getting closer and closer to releasing XML::TokeParser (one which has this functionality built-in), I finally took another look at this thread and realized I too need to do something like that.

D'oh.

I mean, why would you get_tag and then test to see if it's a tag, or a process instruction, since it can only be a tag.

I quickly fixed this and then I got reminded again that a XML::TokeParser::Token doesn't have a constructor -- yuck.

Then I thought maybe I should force get_tag to return a proper token, but that would break backwards compatiblity, and I sure don't wanna do that.

Then I think to myself I should forget all this nonsense, and have

Might as well take full advantage of blessed references. Something like 
package XML::TokeParser::Token;
sub is_text                { return 0; }
sub is_comment             { return 0; }
sub is_pi                  { return 0; }
sub is_tag                 { return 0; }
sub is_start_tag           { return 0; }
sub is_end_tag             { return 0; }
sub raw                    { return $_[0]->[-1]; }

package XML::TokeParser::Token::Text;
# use vars::i '@ISA' => 'XML::TokeParser::Token'; # i'll probably put 
+vars::i on cpan also
use vars '@ISA';
@ISA = 'XML::TokeParser::Token';

sub is_text                { return 1; }
sub text                   { return $_[0]->[-2]; }

[download]
Thoughts/Comments? I think maybe that's what i'll do, because 
sub is_end_tag {
    if( $_[0]->[0] eq 'E'
        or ( @{$_[0]} == 2 && substr( $_[0]->[0], 0, 1 ) eq '/' )
    ){
        if(defined $_[1]){
            return 1 if $_[0]->[1] eq $_[1];
        } else {
            return 1;
        }
    }
    return 0;
}

[download]
does not look so hot. *sigh*

MJD says you can't just make shit up and expect the computer to know what you mean, retardo!
I run a Win32 PPM repository for perl 5.6x+5.8x. I take requests.
** The Third rule of perl club is a statement of fact: pod is sexy.

In reply to Re: Re: XML::TokeParser::Simple - pretty much like HTML::TokeParser::Simple by PodMaster
in thread XML::TokeParser::Simple - pretty much like HTML::TokeParser::Simple by PodMaster

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.