Without getting into any changes to the style of your code. It seems like you could have generic sub that can do both checking and adding if you pass your name and statement as arguments.
sub workItem { my $self = shift; my %args = @_; die "Must supply value for name" unless ($args{name}); die "Must supply value for statement" unless ($args{statement}); my $retval = $self->_execute( handle => 'appfme', statement => [ $args{statement} ], bindvar => [ $args{name} ], output => 1); }

Unless I missed something in your original code this should allow to check and add actors/directors/genre etc.

mr greywolf

In reply to Re: A Better way? (Lots of routines with similar structure) by greywolf
in thread A Better way? (Lots of routines with similar structure) by Ryszard

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.