This looks fishy: 
my $exec = "/usr/local/bin/monster -i$id $filePath$file &";
qx/$exec/;

[download]

Calling exec in scalar context like this, you're feeding what appears to be user input to /bin/sh. If an external user controls the value of $id, $filePath, or $file, you'll get owned because the shell interprets metacharacters. E.g. if $id is set to `rm -rf /`, sh will execute it.

Also, I'm not sure if this is related, but there's no need for the '&' at the end of the command. You've already forked a child, so you shouldn't need to fork again. Try this: 

exec("/usr/local/bin/monster", "-i", $id, "$filePath$file");

[download]
Calling exec() in array context executes the program directly rather than feeding it to the system shell, so metacharacters won't be a problem.

-Matt

In reply to Re: Reaping Zombies (dont wanna wait) by DrManhattan
in thread Reaping Zombies (dont wanna wait) by seaver

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.