That's not PERL, it looks more like Perl ... furthermore, asking people to be gentle is *muffle* ... if you suspect you're doing something dumb, you probably are ... now on to the code

Don't do that!

Was that too loud? Anyway, my @files=`cd $sourcedir && ls`; is yucky, as is
sub cpnewest { copy("$sourcedir$_","$destination$_"); }
Do you know how/why cpnewest works? Do you know why it's a bad idea?

And last but not least, where on earth do you opendir DIR?

You could also use a little more whitespace (indent yer code -- perltidy).

What's the purpose of having @files, @dirlist? Does it really matter that you process/check @files first?

I hope this is enough food for thought (if you're wondering what kind of food, angel-food ).


In reply to Re: Copying all files and subdirectories from one directory to another.. by Anonymous Monk
in thread Copying all files and subdirectories from one directory to another.. by sunshine99

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.