Your code works great for simple cases, but fails for files that have matches that are close together. You end up with duplicate lines being displayed.

for example try the following:

grep.pl -A 1 -B 1 test data

with the file 'data' containing:

test 1
test 2
test 3

[download]

The results are:

test 1
test 2
test 1
test 2
test 3
test 2
test 3

[download]

Also your version will parse the entire file before printing out any results. This will be slow for large files.

Still a good base to start from though...

Cheers

Cees

In reply to Re: (jeffa) Re: linux grep feature by cees
in thread Emulating GNU grep -A and -B switches with perl (was: linux grep feature) by perlisfun

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.