For your code as it is.
To save typing you can define your bag array with range;
You don't need to use the $i variable at all
Use $#bag as your argument to rand instead to generate a random number between 0 and the last index of the array
.
You also don't need to change the value of $x at all.
This would give you
#!/usr/bin/perl -w
use strict;
my @my_bag;
@my_bag = (1..10);
while (@my_bag > 0) {
my $x = int(rand($#my_bag));
print splice(@my_bag, $x, 1) . "\n";
}
Shuffling via rand and splice isn't very efficient though on large arrays. Have a look at perldoc -q shuffle
for an example of a fisher-yates shuffle
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.