Cool thanks for the mods!

Another thing I noticed is that if you make use of the exists command, you can eliminate this loop

foreach my $software (keys %bad_stuff) {
    if($subkey =~ $bad_stuff{$software}) {
        next if($installed_software{$machine.$software}++);
        print "Machine $machine could have $software installed\n";
    }
}

[download]

So it would be something like:

foreach my $subkey ($user_key->SubKeyNames,$software_key->SubKeyNames)
+ {
     if ( exists $bad_stuff{$subkey} ) {
    print "Machine $computer could have $subkey installed\n";
     }
                         
}

[download]

Finally, one other thing concerning the getservers option:

GetServers("", $domain, SV_TYPE_ALL, \%machines) or die "GetServers failed: $!\n";

This will pick up samba servers which will error off since they don't have a registry.

If make use of SV_TYPE_SERVER_UNIX you could build an exclusion section to keep them out. Otherwise, you add to the run time as it tries to open a non-existent registry. I had to do that as I have about 20 of them. There are other issues such as a network appliance box but not everybody has those. I can post code if you are intersted. I figured you like to play so I didn't ;-)

In reply to Re: Scan Win32 Machines in domain for P2P software by Marza
in thread Scan Win32 Machines in domain for P2P software by davis

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.