Hello anonymous,
Try replacing from open() to close() with this snippet:

open(MYFILE, ">$upload_file") || die "Couldn't open upload file: $!\n" +; print MYFILE while (<$fname>); close(MYFILE) || die "Couldn't upload file: $!\n";

This won't give you the file size that you where attempting to assign into $size but 'should' work as far as the upload is concerned. If that works you can then work on getting the size of the file afterwards, this is only to ensure that you can get the upload to work 'at all'.

On matters of security:

I'd *really* add a little foreach loop going through an array of accepted acceptable file extensions (mime types) before the upload section, and then chmod the uploaded file to read only, but that's only IMHO (call me paranoid).

Update: Corrected grammar and added "(mime types)"


In reply to Re: uploaded file is not proper by barrd
in thread uploaded file is not proper by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.