If you are searching through the array multiple times, then right, this isn't the best option. If you are reusing the array to compare against, the best practice is this:

my @array = qw ( a b c d x ); my %hashcheck; @hashcheck{@array} = (); my $sought = 'a'; print "Found!" if exists $hashcheck{$sought};

The reason they suggest not using grep is because it is a O(n) algorithm whereas checking for exists is O(1). When you continuously check @array to see whether or not items can be found, it would be much slower to use grep.

As for their suggestion in the case that the array is checked only once, I could go either way. Their method is actually 17% faster on a million iterations (my benchmarks, YMMV), but I find grep easier to read.

antirice    
The first rule of Perl club is - use Perl
The
ith rule of Perl club is - follow rule i - 1 for i > 1


In reply to Re: Re: Re: Is X in my array? by antirice
in thread Is X in my array? by Not_a_Number

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.