here's a clue:

foreach $server (@servers) {
  chomp $server;
  open TMP, ">/tmp/$server.tmp";
  $ENV{"FILENAME"} = "/tmp/$server\.tmp";
  foreach(@DATA) {
    ($hostid, $time, $get, $post, $currconn) = split(/\t/);
    next if ($hostid ne $SERVER{$server});
    ## more here...
  }
  close TMP;
}

[download]

this is the inefficiency. invert these loops to make this something like:

## iterate through record
foreach(@DATA) {
  ($hostid, $time, $get, $post, $currconn) = split(/\t/);
  ## match against the server list and process accordingly
  foreach $server (@servers) {
    chomp $server;
    next unless $hostid eq $SERVER{$server};

    open TMP, ">>/tmp/$server.tmp";
    $ENV{"FILENAME"} = "/tmp/$server\.tmp";

    ## more here...

    close TMP;

    ## done with this record, move on
    last;
  }
}

[download]

then you'll iterate over the data once, writing to multiple files depending on the $hostid variable. after each data record is processed, it moves on to the next line without evaluating any other servers in the list.

if you haven't already, you might consider using warnings or -w. you might also consider using strict. it would take some work with this code, but it makes perl debugging so much easier.

~Particle *accelerates*

In reply to Re: Super Duper Inefficient by particle
in thread Super Duper Inefficient by Earindil

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.