Hi,

I came around this old code of mine:

# Get the n-th or innermost (if n = -1) argument of # property. Empty string if property isn't parametrized sub get_proparg { my $propstr = shift; # get the property string my $level = shift || 0; # get the level we want to extract my $back = $propstr; # Initialize Return value (for case lev +el=0) my $cnt; # initialize counter if($level == -1) { # special case, get the innermost argum +ent $propstr =~ /\(([^\(\)]+)\)+/; $propstr = $1; } else { # get whatever argument $level indicate +s for($cnt = 0;$cnt<$level; $cnt++) { $propstr =~ /\((.+)\)/; $propstr = $1; } } return $propstr; }
What it basically does is to remove a properties outer peeling like an onion: ;-)
"hello(what(is(this(all(about)))))" 0
get_proparg returned: >>hello(what(is(this(all(about)))))<<
"hello(what(is(this(all(about)))))" 1
get_proparg returned: >>what(is(this(all(about))))<<
"hello(what(is(this(all(about)))))" 2
get_proparg returned: >>is(this(all(about)))<<
"hello(what(is(this(all(about)))))" 3
get_proparg returned: >>this(all(about))<<
"hello(what(is(this(all(about)))))" 4
get_proparg returned: >>all(about)<<
"hello(what(is(this(all(about)))))" 5
get_proparg returned: >>about<<
"hello(what(is(this(all(about)))))" -1
get_proparg returned: >>about<<
As this code happens to be time critical I came around and tried to refactor it. The biggest culprit seems to be the iterative for loop which is of course linear with the number of levels we have to descend. We may surely assume that the parentheses are balanced. But unfortunatedly the mightyness of Regexps doesn't cover "balanced parentheses matching".

Anyone a suggestion how to get rid of the loop?

Bye
 PetaMem
    All Perl:   MT, NLP, NLU


In reply to Peeling the Peelings by PetaMem

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.