Thanks for all your comments.
After reading the posts - especially the benchmarks,
it seems that the code is not as bad as I thought. However
just by looking at it once again and looking at the
"80% speedup" for the level 0 case, I came with 2 improvements:
sub get_proparg {
my $propstr = shift; # get the property string
my $level = shift || return $propstr; # get the level we want to
+extract
my $cnt; # initialize counter
if($level == -1) { # special case, get the innermost argum
+ent
$propstr =~ /\(([^\(\)]+)\)+/;
return $1;
} else { # get whatever argument $level indicate
+s
for($cnt = 0;$cnt<$level; $cnt++) {
$propstr =~ /\((.+)\)/;
$propstr = $1;
}
return $propstr;
}
}
- No need for $back - it wasn't used anyway ;-)
- Immediate return if level = 0; That's straight :-)
- No unnecessary temporary $var = $var assignments
Should perform slightly better now, esp. for the level 0
case (which unfortunatedly is rare).
Bye
PetaMem All Perl: MT, NLP, NLU
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.