This code is crying out for separation of logic and presentation. The idea is that you put all the presentational stuff (ie HTML, error messages, email text) and put them in another file to the code.

Look at Template for a good module for doing this.

At first it will seem like real overkill to do it this way, but it leads to much cleaner and maintainable code. It also means that it is much easier to change the presentational stuff as it is separate.

It is also much quicker to code this way. You can create an email message or HTML page to a fictional user (joe bloggs) in a normal editor, and then wher you are happy you change joe into [% person.first_name %] or whatever.

--tidiness is the memory loss of environmental mnemonics

In reply to Re: CGI script review by EvdB
in thread CGI script review by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.