A few notes:
  1. Use prepare_cached(). These look to be often-called functions. prepare_cached() will reduce the cost after the first one by caching the prepared statement for later use.
  2. If at all possible, don't use "SELECT *" and don't use fetchrow_hashref(). Instead, use "SELECT A, B, C" and bind_columns() and fetch().
To implement the second solution, I'd do something like: 
sub build_selector
{
    my ($dbh, $table, $field, @selectables) = @_;

    my $selectables = join ',', @selectables;

    return sub {
        my ($val) = @_;

        die "No val passed into selector" . $/
            unless defined $val && length $val;

        my $sth = $dbh->prepare_cached(<<"_SQL_");
SELECT $selectables
  FROM $table
 WHERE $field = ?
_SQL_

        die "Couldn't prepare handle: " . $dbh->errstr
            unless $sth;

        $sth->execute($val)
            || die "Couldn't execute handle" . $dbh->errstr;

        my @vals = $sth->fetchrow_array;

        $sth->finish;

        return wantarray ? @vals : \@vals;
    };
}

[download]
Even though it's below, this code is untested. Use at your own risk.

Update: Removed superfluous quotes around the placeholder.

------
We are the carpenters and bricklayers of the Information Age.

Don't go borrowing trouble. For programmers, this means Worry only about what you need to implement.

Please remember that I'm crufty and crochety. All opinions are purely mine and all code is untested, unless otherwise specified.

In reply to Re: Code factory by dragonchild
in thread Code factory by Notromda

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.