I don't think your regexes are right. Assuming that the 'fullname' and 'mother' check names, I wonder why you allow names to contain underscores and digits, but don't allow them to start with an accented letter? Also, the publisher of the Camel and the Lama wouldn't pass the test. Furthermore, the regex for email addresses is just plain wrong. It allows illegal addresses (say foo@...9), but worse, it will reject legal addresses, like $perl$@abigail.nl.

I don't know when you are adding usernames to the system, but you have a problem. You reject usernames that are already in use, but you aren't checking the queue. Say, foo isn't taken yet, dozens of people could submit foo, until the first foo gets added to the system. What will you do with the others, who thought their submission was fine?

Abigail

In reply to Re: Code review: validation regexes by Abigail-II
in thread Code review: validation regexes by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.