Well, when the module continutally tried to search http:/www.nytimes.com instead of http://www.nytimes.com, that was a pretty big tip off that the code wasn't up to snuff. The problem is that he rolled his own instead of using the URI module. Also, when I looked at the guts of the code, the 'new' constructor was 90% of the body of the code. That didn't smell quite right to me either. Then, to pass arugments, he would use code like

sub _save_img { my ($self,$url,$img) = (shift,shift,shift,shift);

Finally the code was littered with numerous #hack comments.

I'm no expert mechanic true. But I do know that if the body is rusted and the interior is a filth pit (not that this code was THAT bad, mind you) there's a good chance the engine isn't worth repairing. I've seen enough professional code before and I know it when I see it. That doesn't mean I can write it.

$PM = "Perl Monk's";
$MCF = "Most Clueless Friar Abbot Bishop Pontiff";
$nysus = $PM . $MCF;
Click here if you love Perl Monks

In reply to Re: Re: Re: Re: Reinvent a broken wheel? by nysus
in thread Reinvent a broken wheel? by nysus

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.