Nice solution.
Downsides:
- This recreates the 62 element list repeatedly in memory, since there's
no place to store it.
- The number "62" is hardcoded, and must match the list exactly. That's
a maintenance headache: suppose a requirement came along to ensure that
underscore were included, or that digits were not.
- The int is redundant.
Implementing these three changes, I'd go with something like:
BEGIN {
my @source = ('A'..'Z', 'a'..'z', '0'..'9');
sub generate_random_password {
my $id = "";
for (1..18) {
$id .= $source[rand @source];
}
$id;
}
}
For so-called "pronounceable" passwords, try
Crypt::RandPasswd. Looks nice, and based on a government standard.
-- Randal L. Schwartz, Perl hacker
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.