Hi Monks,
I have written a subroutine to test if a user is in the database or not. It returns 1 if the user is in the database and 0 if the user is not in the database.
Here is the code i have written: 
sub member_exists 
{
my ($email,$mid) = @_;
chomp ($email,$mid);
my $db = "nMail";
my $sock = "/tmp/mysql.sock";
my $user = "";
my $pass = '';
my $dsn = "DBI:mysql:$db;mysql_socket=$sock";
my $mid = ();

my $dbh = DBI->connect($dsn,$user,$pass);
my $sth = $dbh->prepare("SELECT S_Email,MID FROM ML_Subscribers");
$sth->execute() || die "Error: Could not get mailing list data\n";
while (my @row = $sth->fetchrow_array) {
        if($row[0] eq $email and $row[1] == $mid){
                return 1;
        }
}
$sth->finish();
$dbh->disconnect();
return 0;
}

[download]
However this will always return 0 for all cases. When i remove  and $row[1] == $mid it works fine, but i need the $email and $mid to be the same. I've tried changing "==" to "eq" but that doesn't work either.

I have also tried the sql statement:  SELECT S_Email,MID FROM ML_Subscribers WHERE MID = '$mid' AND  S_Email = '$email' and then tested if  $row[0] is true.
None of these things worked so i am pretty stuck for ideas.
I'm sure it has to be something stupid i am over looking, i would appreciate any input.
Cheers

Neil Archibald
- /dev/IT -

In reply to SQL - Subroutine always returning true by devslashneil

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.