I've got a function that accepts a comma-delim string of RGB values between 0 and 255. I need to convert that to an array of 3 values between 0 and 1. This is for a module I'm working on for release to CPAN, so this will be the first time I'm seeing these values. The input-massaging code I have right now is:
my ($color, ...) = @_;
$color ||= '';
my @colors =
map { s/[^\d.-]//g; $_ ||= 0; $_ < 0 ? 0 : $_ / 255 }
(split(/\s*,\s*/, $color, 4), (0) x 3)[0..2];
Can anyone see that I missed anything? Are there any improvements I can make? Am I being too anal or DWIM-ish? Right now, I have no error messages back to the user. Is this a bad thing? As for the line-noise potential, this is the only place this logic will be used. (One idea, one place kind of thing.)
------
We are the carpenters and bricklayers of the Information Age.
Don't go borrowing trouble. For programmers, this means Worry only about what you need to implement.
Please remember that I'm crufty and crochety. All opinions are purely mine and all code is untested, unless otherwise specified.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.