You could outfactor(?) the combined ifs:
If NAME =~ /BAA/
if ITEMS_A =~ /^134/
if ITEMS_B =~ /^134/ THEN
TBAA+=SUM
a++;
elsif ITEMS_B !~ /^(134|00)/ THEN
OBAA+=SUM
b++;
elsif ITEMS_B =~ /^00/ THEN
IBAA+=SUM
ab++;
else
EBAA+=SUM
c++;
# AFAICS this will never be reached.
# Either ITEMS_B starts wit 134 or 00 or something
# else. The last case is targeted by your second
# ITEMS_B-if
To shorten it, or at least make it more switch-like, in perl you could use the aliasing to $_ or "for":
SWITCH: for ($ITEMS_B) {
/^134/ && do {
# see above
last SWITCH;
};
!/^(134|00)/ && do {
# see above
last SWITCH;
};
/^00/ && do {
# see above
last SWITCH;
};
# else
do {
#see above
last SWITCH;
}
}
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.