The problem is that you are shelling out and doing a dir /s of an entire drive in order to extract the size from the second from last line.
Even on my half empty 2GB boot partition, this results in 1.5 MB of data and 36,000 lines!
On a share that points to a well used 40GB drive with compression enabled, this could easily lead to a list of files of several 10s of MB and 200,000 lines or more. Pulling all this data across the network and into an anonymous list just to find out the amount of space used on a remote share is ... well more than just slightly profligate.
There are a number of vastly more efficient ways (in terms of memory, time and network load) of getting this information. The question has comes up at least three times in the last week or so, including this one. A Super search for "disk usage" or "share size " should turn up several more.
Examine what is said, not who speaks.
"Efficiency is intelligent laziness." -David Dunham
"When I'm working on a problem, I never think about beauty. I think only how to solve the problem. But when I have finished, if the solution is not beautiful, I know it is wrong." -Richard Buckminster Fuller
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.