Well, yes, but he did say he was trying to shorten his script :)
I am often a chooser of elegance (subjective, of course) over efficiency.
So, to combine some efficiency with some elegance:
while($line = <F>) {
for my $hit ($line =~ /matchPattern/gi) {
$ct++;
push @files, $name;
print "PAGE ->\t$name\ndata ->";
if( $line =~ /(patternOne)/i or $line =~ /(patternTwo)/i ) {
print "\t\t$1\nMATCHED - >\t$hit\n";
}
else {
print " TEXT INFO HERE.\n";
}
}
}
The
$1 will be properly remembered -- although if a line matches both patterns is the
or a short circuit operator? You might have to switch the order to keep the behavior identical.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.