I hate suggesting this, but it will probably make the out-of-memory problem go away with the least effort:)

Change

my ($Size)=( (qx{dir /s "$TargetPath"})[-2]=~ /([\d,]+) bytes/ );
[download]

to

my ($Size)=( (qx{dir /s "$TargetPath" | find "bytes" })[-2]=~ /([\d,]+
+) bytes/ );
[download]

That will filter out the vast majority of the lines produced by the dir /s before they get into perl.

If you have WSH available, then you can use

use Win32::OLE;

my $size = Win32::OLE->CreateObject('Scripting.FileSystemObject')
    ->GetFolder( $TargetPath )
    ->size();
[download]

Which probably isn't hugely more efficient than dir /s in terms of doing the calculation, but it will prevent the memory problem.

You could also accumulate the directory sizes directly in perl

my (@dirs, @files) = ($TargetPath);
scalar map{ 
    push @{ (-d) ? \@dirs : \@files }, $_ 
} glob pop(@dirs) . '/*' while @dirs;
my $size += -s for @files;
[download]

Which from my quick tests is much faster than shelling out, and seems to be quicker than using an FSO but it's difficult to measure as file system catching gets involved.

You could also use any of the many File::Find modules to achieve the same effect.

---

Examine what is said, not who speaks.

"Efficiency is intelligent laziness." -David Dunham
"When I'm working on a problem, I never think about beauty. I think only how to solve the problem. But when I have finished, if the solution is not beautiful, I know it is wrong." -Richard Buckminster Fuller

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.