Try downloading the tar/gz I have just created for you on my website

Your assistance is certainly generous and well-intentioned, but I think it would be best if we didn't encourage posting links to scripts on our personal sites. It would have been better to simply include the source of your script, all 184 lines of it, between a couple readmore tags.

The simplest view is that, when avoidable, it is best not to make a node dependent on an external site for completeness. There are, however, far more compelling (security) reasons. Unfortunately, they are quite subtle and easily overlooked.

It is very important that the code provided in our answers be readily available for peer review. You might say that it was; anyone could download the code and look at it. That's not necessarily true. You can't tell who might be checking up on the site from an internet cafe, mall kiosk, or school library. Some may even decline to download the package simply because they don't want to reveal their IP to you (which might expose their place of employment, for instance.)

It is also important that, when we do review code, we can all be sure we are talking about the same thing. A link on an external site may easily be made to look like one thing to one person and another to someone else. Hence, in this case, all I can say is that the code that I downloaded from your site looked clean after a quick inspection. I have no idea about anything that anyone else downloaded.

-sauoq
"My two cents aren't worth a dime.";

In reply to Post Code, Not Links! (was: Re^10: code problem) by sauoq
in thread code problem by sandal

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.