As fglock points out, you are shadowing $weekStr with another declaration of it at the end of your first for loop.

You might reconsider your indentation style. It makes some of those errors easier to spot if you can more easily see what is in a block and what isn't. I recommend using perltidy. I fed your code into it, made one small change¹, and this was the result: 

sub getWeekStr {

    my ( $week1, $week2, $week3, $week4 ) = @_;
    my $weekStr;

    for ( my $x = 1 ; $x <= 4 ; $x++ ) {
        my $WEEK_PD      = 'WEEK' . $x;
        my $stored_num   = $_[ $x - 1 ];
        my $WEEK_PD_NAME = 'WEEK' . $x . "_PD";

        $WEEK_PD_NAME = qq|<SELECT NAME="$WEEK_PD">|;

        $WEEK_PD =~ s/WEEK//;

        for ( my $y = 1 ; $y <= 4 ; $y++ ) {

            if ( $y =~ /$stored_num/ ) {
                $WEEK_PD_NAME .= qq|<option selected value = |
                              .  qq|"$stored_num">TEAM $stored_num</OP
+TION>|;
            }
            else {
                $WEEK_PD_NAME .= qq|<option value = "$y">TEAM $y</OPTI
+ON>|;
            }

        }

        $WEEK_PD_NAME .= qq|</SELECT>|;

        print $WEEK_PD_NAME;

        my $weekStr .= qq|<td align=center width=25%>$WEEK_PD_NAME </t
+d>|;

    }
    return $weekStr;
}

[download]

I broke up your long qq|| string into two and concatenated them.

-sauoq
"My two cents aren't worth a dime.";

In reply to Re: Re: Re: returning values by sauoq
in thread returning values by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.