Because you passed $colour by value, as opposed to $rightwrong, which was passed by reference. In the former case the method gets a copy of the state the variable had at invocation time. Obviously then you can change the variable all you like - it won't change the copy. To do what you wanted, you need to reconfigure the widget. 
# ...

my $rw = $mw->Label(-textvariable => \$rightwrong,
           -foreground => $colour)->pack(-side=> 'bottom');

# ...

    if ($answer == $guess) {
        #count correct answers
        $correct++;
        $rightwrong = 'Correct!';
        $rw->configure(-foreground => 'green');
    }else{
        $rightwrong = 'Wrong!';
        $rw->configure(-foreground => 'red');
    }

# ...

[download]
(If I am allowed a personal comment, I really hate Tk's way of using pass-by-reference to keep track of changes. It leads to spaghetti code real quick like.)

Makeshifts last the longest.

In reply to Re: More Perl/Tk help. by Aristotle
in thread More Perl/Tk help. by neilwatson

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.