It seems like you will inspect each 'd=' part twice. After finding an 'o=' thing, you start with a new index, $j = $i + 1, scanning for 'd=' thingies. If you find one or more, you increment $j, but not $i. Personally, I'd make two nested loops, both of the form while (@query_string), and both shifting off elements.

Also, it seems that if you have a string of the form:

o=foo&d=one&d=two&o=foo&d=three

you just end up with foo => 'three'.

Personally, I would write the final assignment as:

$args {$o} = \@opts;

so that my values are always array refs, and I don't have to make cases in the rest of the code.

Abigail


In reply to Re: Reinventing wheels: query string parsing. by Abigail-II
in thread Reinventing wheels: query string parsing. by BUU

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.