HI,

This is my perl : 
if ( defined $osname{$num1} ) {
   if ( $osname{$num1} =~ /INTIM/ ) {
      $ototalintimdur+=$dur;
      $ototalintimcdr++;

        if (defined $freecall{$bnum} ) {
            $ointimfreedur+=$dur;
            $ointimfreecdr++;

         } elsif ( defined $voicemail{$bnum} ) {
               $ointimvoicedur+=$dur;
               $ointimvoicecdr++;
....

} elsif ( $osname{$num1} =~ /TOUCH/ ) {
       $ototaltouchdur+=$dur;
       $ototaltouchcdr++;
      
     if (defined $freecall{$bnum} ) {
          $otouchfreedur+=$dur;
          $otouchfreecdr++;

      } elsif ( defined $voicemail{$bnum} ) {
          $otouchvoicedur+=$dur;
          $otouchvoicecdr++;
 .....

[download]

Actually, they are alot of calculation here but I have taken some of them as an example. This calculation would be repeat in different situation which are based on $osname{num1}, which are INTIM and TOUCH. Using IF, ELSIF and ELSE method, they are not very nice. I think they can make very simple and easier using subroutine or object, if I'm not mistake. Then, Any body can guide me how to do that ?

Thank you,
bh_perl

edited: Mon Jul 28 14:44:07 2003 by jeffa - code tags, removed br tags

Title edit by tye

In reply to Simplifying a nest of if statements by bh_perl

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.