Suggested title for parent node: "Simplifying a nest of if statements."

I think that a table-driven approach might make the logic of what you're doing more evident: 

my @cases = (
  { 
    osname => 'INTIM', 
    total => {
      duration => \$ototalintimdur, counter => \$ototalintimcdr.
    },
    freecall => {
      duration => \$ointimfreedur,  counter => \$ointimfreecdr.
    },
    voicemail => {
      duration => \$ointimvoicedur, counter => \$ointimvoicecdr.
    },
  },
  { 
    osname => 'TOUCH', 
    total => {
      duration => \$ototaltouchdur, counter => \$ototaltouchcdr.
    },
    freecall => {
      duration => \$otouchfreedur,  counter => \$ototaltouchcdr.
    },
    voicemail => {
      duration => \$otouchvoicedur, counter => \$otouchvoicecdr.
    },
  },
)

if ( defined $osname{$num1} ) {
  foreach my $case ( @cases ) { 
    next unless $osname{$num1} =~ /$case->{osname}/;
    my $calltype = ( defined $freecall{$bnum}  ) ? 'freecall'  :
           ( defined $voicemail{$bnum} ) ? 'voicemail' : 
                            undef;
    my @counter_sets = map $case->{$_}, grep $_, 'total', $calltype;
    foreach my $counters ( @counter_sets ) {
      ${ $counters->{duration} } += $dur;
      ${ $counters->{counter}  } ++;
    }
    last;
  }
}

[download]

In reply to Re: Subroutine by simonm
in thread Simplifying a nest of if statements by bh_perl

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.