Couple of things:
1. if /matchdata/ has any capturing () than $name is pushed into @files for each ().
2. When you do @data = (<LDATA>) you read the entire file into memory. A better way to do this would be: 
foreach  (@files)
{
    open(LDATA, "$_") || warn "File does not open: $!\n";
    open(TMP, ">$_.tmp") || warn "File Write problem $_.tmp: $!\n";
    
    while (<LDATA>)
    {
        s/OLD/NEW/gi;
        print TMP $_;
    }
    close(LDATA);
    close(TMP);
    rename("$_.tmp", "$_") or warn "Could not rename '$_.tmp' to '$_':
+ $!\n";
}

[download]
Another side advantage of this is that if, for some reason, your script dies half way through then you still have our old file rather than a half written new file. hth.

$will->code for @food or $$;

In reply to Re: Re: Re: Re: Checking Perl script on server by smalhotra
in thread Checking Perl script on server by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.