You are nesting your global variables.
use strict; and declare them correctly. You're unnecessarily pushing your directories twice into @dir, so skip that line. Also grep only the desired files from the directory listing, adding a
grep { !/^\.\.?$/ }, which ignores "./" and "../".
This should work:
use strict;
my @dirs;
my $directory = "D:/Temp";
getdirs($directory);
for my $dir (@dirs) {
update($dir);
}
print "DONE\n";
sub getdirs {
my $directory = shift;
opendir (DIR, $directory);
my @files = grep { !/^\.\.?$/ } readdir DIR;
closedir DIR;
push (@dirs, $directory);
for my $file (@files) {
if (-d "$directory/$file") {
getdirs("$directory/$file");
}
}
}
Finally, as
simon.proctor mentioned, I'd really recommend using File::Find for this kind of job.
--
trust in bash
but tie your camel
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.