I would focus on getting the code correct before I worried too much about getting it cleaned up. 
  my $regex = $required_params{$param};

[download]
isn't doing what you expect it to. $regex ends up holding an anonymous array. You need something like 
  my $regex = $required_params{$param}[0];

[download]
(You correctly use $required_params{$param}[1] later to pick off the size, which leads me to suspect that you're posting partially debugged code.)

Even then, the regex you're using looks suspect, unless you intend to allow a string that has at least one "word" character. Also, a match sets $1, which there's no evidence of the coding using.

My suggestion: Get this working first. Write unit tests if you have to. Then clean it up. You can try to worry about correctness and cleanliness at the same time, but my experience is that it'll take you 50% more time (or more) if you go that route.

In reply to Re: Code Cleanup challenge! by dws
in thread Code Cleanup challenge! by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.