Hi all, I inhereted some code that I'd like to clean up. Any way
in doing this with fewer lines.
Thanks,
Mark
my @short_org_name = keys %myorgs; my $count=2; my $frame; foreach (@short_org_name) { my $score = $hits{$myorgs{$title_order{$count}}}; if ($score eq "NoHit") { $frame = $tab->Label(-bg => 'black', -relief => 'sunken' +, width => 15); $balloon->attach($frame,-balloonmsg => "No Hits"); } else { if ($score == 0) { $frame = $tab->Label(-bg => 'red', -relief => 'sunken +', width => 15); $balloon->attach($frame,-balloonmsg => "E = 0"); } if (1e-99 <= $score && $score < 1e-90) { $frame = $tab->Label(-bg => 'orange', -relief => 'sun +ken', width => 15); $balloon->attach($frame,-balloonmsg => "1e-99 < E < 1 +e-90"); } if (1e-90 <= $score && $score < 1e-80) { $frame = $tab->Label(-bg => 'gold', -relief => 'sunke +n', width => 15); $balloon->attach($frame,-balloonmsg => "1e-90 < E < 1 +e-80"); } if (1e-80 <= $score && $score < 1e-70) { $frame = $tab->Label(-bg => 'yellow', -relief => 'sun +ken', width => 15); $balloon->attach($frame,-balloonmsg => "1e-80 < E < 1 +e-70"); } if (1e-70 <= $score && $score < 1e-60) { $frame = $tab->Label(-bg => 'chartreuse', -relief => +'sunken', width => 15); $balloon->attach($frame,-balloonmsg => "1e-70 < E < 1 +e-60"); } if (1e-60 <= $score && $score < 1e-50) { $frame = $tab->Label(-bg => 'green', -relief => 'sunk +en', width => 15); $balloon->attach($frame,-balloonmsg => "1e-60 < E < 1 +e-50"); } if (1e-50 <= $score && $score < 1e-40) { $frame = $tab->Label(-bg => 'turquoise', -relief => ' +sunken', width => 15); $balloon->attach($frame,-balloonmsg => "1e-50 < E < 1 +e-40"); } if (1e-40 <= $score && $score < 1e-30) { $frame = $tab->Label(-bg => 'blue', -relief => 'sunke +n', width => 15); $balloon->attach($frame,-balloonmsg => "1e-40 < E < 1 +e-30"); } if (1e-30 <= $score && $score < 1e-20) { $frame = $tab->Label(-bg => 'pink', -relief => 'sunke +n', width => 15); $balloon->attach($frame,-balloonmsg => "1e-30 < E < 1 +e-20"); } if (1e-20 <= $score && $score < 1e-10) { $frame = $tab->Label(-bg => 'purple', -relief => 'sun +ken', width => 15); $balloon->attach($frame,-balloonmsg => "1e-20 < E < 1 +e-10"); } if (1e-10 <= $score && $score < 1) { $frame = $tab->Label(-bg => 'grey', -relief => 'sunke +n', width => 15); $balloon->attach($frame,-balloonmsg => "1e-10 < E < 1 +"); } }

20030817 Edit by Corion: Fixed formatting


In reply to doing the same thing but with less code by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.