Does getparam() have function specific arguments? If not, call it once in execCommand(), and have it pass the results to the subroutines being called.

That way, if it fails you can print your error and return to the while loop immediately.

For that matter, you could have getParam() itself print warnings on error, put it in the while loop, and not even call execCommand() if it fails.

On a side-note, if 0 is always a failure, you can replace your if statements with:

&getParam() or return 0;

[download]

That's nicer to look at IMO, but TIMTOWDI and YMMV. :)

- Matt Riffle
  Sr. Systems Programmer, pair Networks, Inc.
  (although, I'm speaking only for myself; code is untested unless otherwise stated)

In reply to Re: CLI and problems by mattriff
in thread CLI and problems by hotshot

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.