One, for long hand-authored regexen like this, try using the /x modifier. It would avoid the whitespace error and make your example easier to read as well.
my $ignore =
qr( 192\.168\.188\.3 |
192\.168\.11\.141 |
192\.168\.140\.110 |
192\.168\.186\.192 |
192\.168\.186\.166 |
192\.168\.139\.50 |
192\.168\.139\.198 |
192\.168\.132\.101 )x ;
Two, build your regexp from a data table. This gives the opportunity to use modules like
Regex::PreSuf to optimize long lists. Think of all the time wasted in backtracking on the "192.168." part over and over.
use Regex::PreSuf;
my @ignore =
qw( 192.168.188.3
192.168.11.141
192.168.140.110
192.168.186.192
192.168.186.166
192.168.139.50
192.168.139.198
192.168.132.101 );
my $ignorex = presuf( map { s|\.|\\.|g } @ignore );
Lastly, now that the list of ignored IPs is really a list, it can come from a configuration file instead of from the script itself.
--
[ e d @ h a l l e y . c c ]
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.