You actually want:
foreach (@lines) { if(/(\w+)\s+(\w+:\w+)\s+(\d+\.\d+\.\d+\.\d+):\w+\s+(\w+)/) { $protocol = $1; $localAddress = $2; $foreignAddress = $3; $state = $4; print "$protocol, $localAddress, $foreignAddress, $state\n"; } }
This is because if a line fails to match, perl will not reset $1, $2, $3, $4, so they will still have a value from the previous match.

Also, if you are not going to use the @lines array for something else, it's much more memory-efficient to combine the loops like this:

open NETSTAT, "$program|" or die "Cannot open netstat $!\n"; while (<NETSTAT>) { if(/(\w+)\s+(\w+:\w+)\s+(\d+\.\d+\.\d+\.\d+):\w+\s+(\w+)/) { print "$1, $2, $3, $4\n"; # protocol, localAddress, foreignAddress, state } }

In reply to Re: Help with warnings!!! by Thelonius
in thread Help with warnings!!! by jmaya

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.