I usually do something like this: 
sub do_something {
  my $args = shift;
  my $result = 0;  # or "", or undef, or whatever
  my @errors = ();

  # Validate staff
  push @errors, "Where's the email?" unless ($args->{email});
  push @errors, "Bad email" unless ($args->{email} =~ /\@/);
  # ...

  unless (@errors) {
    # Do something here
    # ...
  }

  return $result, @errors;  
}

[download]

This approach provides a convinient way to display errors later on, if need be, while still validating provided data and saving on processing if ugly staff was given. 

sub display_status {
  my @errors = @_;
  if (@errors) {
    print "Operation failed due to following errors:\n";
    foreach my $error (@errors) {
      print "\t- $error\n";
    }
  }
  else {
    print "Operation succeded\n";
  }
}

[download]

Now, if you need to display only errors you can do: 

my ($result,@errors) = do_something(\%args);
if (@errors) {
  display_status(@errors);
}

[download]

If you need to show to the user an OK message too, then just call display_status(@errors) unconditionally.

my two cents

Leonid Mamtchenkov aka TVSET

In reply to Re: How to return errors from my object oriented subroutine by TVSET
in thread How to return errors from my object oriented subroutine by princepawn

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.