Using /g in the scalar context of an if statement is probably superfluous.

s/superfluous/a mistake/. //g in a scalar context can make your match fail every so often. I've seen this type of bug reported here several times.

This particular code, in isolation, probably wouldn't notice the bug (perhaps that is what you meant) since $str appears to be getting updated at least once per regex application. But the use of //g in a scalar context is something that should be vigorously avoided unless you need that advanced magic and understand it.

I've seen this mistake enough that I'd support a pragma that makes this illegal unless you ask for it. But, in practice, I don't see how to make such useful.

                - tye

In reply to Re^2: matching digits and characters (scalar //g) by tye
in thread matching digits and characters by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.