Well,

Like the others here I sometimes decalre a database handle as a global, it is perfectly valid to do so.

On the other hand, I think it is far more elegant and easier to 'self-document' your code if you pass the handle into the sub. I got caught big time just a few days ago. I was using the $dbh as a global, then I realised that I needed to connect to a second database on another machine to get some data. To avoid duplicating the database subs I went back and passed the handle in to the subs so I didn't have a maintenanace nightmare.

It only takes one line of code (maybe only a part of a line!) per subroutine, but for me it has been a lifesaver when I do it, and the one time I don;t do it - I get caught!

As always, YMMV & TIMTOWTDI, good luck!

jdtoronto

In reply to Re: Is this Bad form? (DBI) by jdtoronto
in thread Is this Bad form? (DBI) by Grygonos

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.