I would like to add a few things I've learned from experience.
I would change:
my $extlist = join('|', @extensions);
to
my $extlist = join('|', map {quotemeta} @extensions);
in case members of
@extensions contains some metacharacters. There might be an extension
file.(myextension)
I'd also change:
my $re = qr/some_text=".*\.(?:$extlist)"/;
to
my $re = qr/some_text=".*\.(?:$extlist)"$/;
because you never know if someone has a file named something like
"file.123".backup
It doesn't matter in these simple examples but when you try using it in the real world you never know what you will get. I try to think of pathological cases because most users are, well, pathological. Someone else will probably have some better suggestions on my code. They will probably be speaking from experience (of pathological users).
--
flounder
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.