This:

$line =~ m/\s*(\S+)\s*(\S+)\s*(\S+)\s*(\S+)\s*/;

is a really bad way to split a line on whitespace. It will do all sorts of things you don't want in edge case situations. See this Re: ('Re: ' x 6) How to remove the $1 hard coding and its parent thread.

my ($device, $bps, $sps, $msps ) = split ' ', $line;

Is far more robust, self documenting, and also faster way to split a file like the one you have into fields.

Makes no difference to the functionality but:

sub PlotGraph { my $worksheet = shift; my $col = shift; my $row = shift; my $chartTitle = shift; my $xAxisTitle = shift; my $yAxisTitle = shift; # reads better to my eye and makes it easier to see the function(args) + # (also a bit faster FWIW) sub PlotGraph { my ( $worksheet, $col, $row, $chartTitle, $xAxisTitle, $yAxisTitle ) + = @_;

cheers

tachyon

s&&rsenoyhcatreve&&&s&n.+t&"$'$`$\"$\&"&ee&&y&srve&&d&&print


In reply to Re: Format iostat output into excel graphs to analyse disk io bottlenecks by tachyon
in thread Format iostat output into excel graphs to analyse disk io bottlenecks by abhishes

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.