If you use <CODE></CODE> tags around your post, your code will show up much cleaner.

Just glancing through your stuff, I can see some serious problems. The first thing you need to do is change your shebang line to:

#!/usr/local/bin/perl5.005 -Tw
The -w turns on warnings, but it's the -T that you should really pay attention to here. Specifically, read about security to appreciate the security hole that you have opened up here. As it stands right now, you've allowed someone to pass server side includes into the first Web page generated above. There may be other security problems (I'm not terribly conversant with sendmail issues, but I'd be nervous about tainted data in the To: and From: lines. merlyn mentions this danger on a response to your previous post.

Your javascript redirect is not going to work if the person has javascript turned off (and some browsers are just plain flaky). You can redirect in Perl with the CGI module doing the following:

print $query->redirect('http://wwwdev.pl.ford.com/L2e/cgi-bin/ebook_in +sert_2.cgi');
The last time you posted, turnstep made a suggestion that you apparently did not try:
$dbh->insert_row('il2e009_bk_review',\%review) or die "Insert failed: +$DBI::errstr\n";
If you are getting this far in your script and it fails here, this will print a short failure message which should give you more information about the error. This is one of the many things that you should never attempt without checking the return code (other things are opens, switching directories, and things that you have minimal control over).

Hope this helps!

Cheers,
Ovid


In reply to (Ovid) Serious trouble in CGI script by Ovid
in thread Trouble passing values through hidden fields by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.