This code could stand a lot of improving. I suggest you start from scratch and do things the "right" way (to name a few: don't open, read, reopen, then reread files just to get the Nth line, don't assign to
$., don't pass data to subs using global variables, don't clobber
$_, etc)...
Tie::File will save you a lot of time. I suggest something like this:
use strict;
use Tie::File;
foreach my $file (readdir DH) {
## skip hidden files
next if $file =~ /^\./;
my @lines;
tie @lines, 'Tie::File', $file
or die "Couldn't open $file: $!";
## skip files where the first line contains "Clock"
next unless $lines[0] =~ /^Clock/;
## grab CSV timestamp info from 4th line and last line
my $start = ( parse_csv( $lines[3] ) )[0];
my $end = ( parse_csv( $lines[-1] ) )[0];
## prepend lines to the file: modifying the array modifies the fil
+e
unshift @lines, "PREPEND LINE1",
"blank,blank,blank,$start,$end";
}
You should also consider using
Text::CSV or
Text::CSV_XS for parsing CSV data, so you don't have to worry about maintaining that CSV regex.
blokhead
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.