I've been doing Perl for about 5 years, and I'm *NO* expert, but I have to say that to me that is at least somewhat obfuscated code. I have no problem with the while, but the foreach:
foreach my $num (split /::/ => $value) {
mystifies me - what is the split splitting? When split isn't given an arg to split, it splits $_, but what is $_ in this case, since the while loop gets $key and $value?
IMHO, more straightforward code, albeit sometimes longer code, is better:
my %matches = map {$_ => 1} 17, 83, 114, 205, 407;
while (my ($key, $value) = each %hash) {
my @value_tokens = split /::/, $value;
foreach my $value_token (@value_tokens) {
if ($matches{$value_token}) {
print "$key: $value\n";
$found = 1;
last; ### break out of foreach
}
} ### end foreach
if $found:
next;
}
} ### end while
I'm not entirely sure I understand the original intent, so this solution may need some work.
HTH.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.