Any help optimizing this slow code would be great.

Good advice on profiling aside, I would start with the query and database schema. A lot of time can get chewed up by an inefficient query, or one that could be sped up by adding indexes.

Look at the query 

  select text_id,gene_name,protein5,protein3
  from protein
  where org_id=$orgid
  order by protein5 desc"

[download]
and ask two questions:
  1. Is there an index on org_id?
  2. Is it really necessary to have the database sort the results?
Unless org_id is indexed, the database must make a linear scan over the protein table. If the table is big, the scan can be slow. If the field is indexed, the retrieval will usually be considerably faster (except in cases where you're going to match most of the records anyway.)

I can't tell from your code whether it matters whether the query results are sorted or not. If it doesn't matter, drop the order by clause.

The non-SQL thing that jumped out was the redundant trig calculations. You're doing each sine and cosine calculation twice, where once would be sufficient.

Then profile.

In reply to Re: sloooowwwwww code! by dws
in thread sloooowwwwww code! by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.