I don't get why you prepare the SELECT statement inside the loop. There's nothing variable in it... So put the prepare phase upfront.

Also, you don't need separate prepare/execute/finish statements for an UPDATE query. You can replace it with one single do() (the DBI method).

Alternatively, again, prepare the handle for the UPDATE query outside the loop. The code could look a bit like this:
Version 1: 

    $query = q{SELECT Referrals.1, Referrals.2, Referrals.3,
                      Referrals.4, Referrals.5,
                      Referrals.6, Referrals.7, Referrals.8,
                      Referrals.9, Referrals.10, 
                      Referrals.11, Referrals.12,
                      Referrals.13, Referrals.14, States.1
                      FROM   Referrals
                      INNER JOIN States On (Referrals.10 = States.1)
                      WHERE AuditID = ?};
                         
    my $sth = $dbh->prepare($query);
    foreach my $audit (keys(%$audits))
    {
        $sth->execute($audit);
        my @assign = $sth->fetchrow_array;
        $sth->finish();
            
        $dbh->do(q{INSERT INTO report_printing_table
                   (1,2,3,4,5,6,7,8,9,10,11,12,13)
                   VALUES (?,?,?,?,?,?,?,?,?,?,?,?,?)},
          undef, $audit, @assign);
     }

[download]
or Version 2: 
    $query = q{SELECT Referrals.1, Referrals.2, Referrals.3,
                      Referrals.4, Referrals.5,
                      Referrals.6, Referrals.7, Referrals.8,
                      Referrals.9, Referrals.10, 
                      Referrals.11, Referrals.12,
                      Referrals.13, Referrals.14, States.1
                      FROM   Referrals
                      INNER JOIN States On (Referrals.10 = States.1)
                      WHERE AuditID = ?};
                         
    my $sth = $dbh->prepare($query);
    my $updh = $dbh->prepare(q{INSERT INTO report_printing_table
       (1,2,3,4,5,6,7,8,9,10,11,12,13)
       VALUES (?,?,?,?,?,?,?,?,?,?,?,?,?)});

    foreach my $audit (keys(%$audits))
    {
        $sth->execute($audit);
        my @assign = $sth->fetchrow_array;
        $sth->finish();
            
        $updh->execute($audit, @assign);
    }

[download]
There's no need for a finish() call for an UPDATE query.

Maybe, just maybe, this also fixes your problem.

In reply to 3Re: Optimization/Efficiency Question by bart
in thread Optimization/Efficiency Question by Grygonos

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.