Here is a brief list
  1. line 1 - no -T and no -w
  2. line 2 - no "use strict;" (and no "use warnings;")
  3. line x - variable scoping issues (very bad)
  4. line x - no style (perltidy should be run)
  5. line x - comments are either incomplete or useless (see line 142-146 for example, the comment is "# Clean up" followed by $sth->finish();)
  6. line 42 - he prints $name, no entities escaping is done -- he does this EVERYWHERE
  7. line x - no cleaning of any param values is done -- hello spam relay
  8. line 97 - use of `date '+%D'` -- what's next, he's gonna shell out for sort?
  9. line 125 - like with the spam relay, his database is open to corruption (this makes me think DBI ought to protect idiots from themselves like java does with executeQuery/executeUpdate)
  10. line 189 - needless repetition - if he doesn't know my can take a list, he doesn't know many other things

In reply to Re: How many security holes can you find? by Anonymous Monk
in thread How many security holes can you find? by dragonchild

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.