7. line x - no cleaning of any param values is done -- hello spam relay

While I agree that cleansing input is important, it seems unfair to label this script as a "spam relay".

I haven't read every line of this script, but from what i can see the emailing functionality is used in 3 places. 2 of these are messages sent to hard coded email address, (yeah for common sense). THe third is in fact sent to an address specified via the form input -- but since the point of the script is to send an email confirming that the address is valid for registration, there's not a lot of ways arround that.

The email sent will definitely contain information about where it came from, including why it was sent, and how to "Opt Out" -- including a phone number (which I have to applaud the inclusion of). In fact, the only means a malicious user has to infuence the body of this message is via "$name ... and that's not even a value they are allowed to submit directly, it must be the "username" portion of the email they want to send.

This script may have a lot of issues, but being an open relay doesn't seem to be one of them.

In reply to Re: Re: How many security holes can you find? by hossman
in thread How many security holes can you find? by dragonchild

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.