Two related problems: Checks for e-mail address validity by looking for an '@' and a '.' and parses the user portion of the e-mail address by splitting at the first '@'.

The first is wrong because parsing an e-mail address is a lot harder than most people think. Now, because this is Perl, somebody mercifully wrapped up the hard part inside Mail::Valid (and other modules as well, but that's the one I usually use). Using that module will take you two lines, including the use statement.

For the second part, it is perfectly valid to have more than 1 '@' in an e-mail address (which goes back to the problems in parsing e-mail addresses). This is used to specify relays to put a message through. Admittedly, this is really a mis-feature that most MTAs no longer allow because it is too easy to use for spam.

The way you want to get the user portion of the address is to use Mail::Address's user() method. This will take a whopping three lines of Perl (gasp!).

----
I wanted to explore how Perl's closures can be manipulated, and ended up creating an object system by accident.
-- Schemer

Note: All code is untested, unless otherwise stated

In reply to Re: How many security holes can you find? by hardburn
in thread How many security holes can you find? by dragonchild

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.