And what is 
  close ARGV if eof;

[download]
supposed to be doing? Is there a file handle named ARGV that you opened previously? If so, that's the not the right way to test for eof.

The answer is yes, there is a file handle named ARGV. And IMO, the use of eof is the right way to test for eof. Here's a quote from perldoc -f eof: 

               In a "while (<>)" loop, "eof" or "eof(ARGV)" can
               be used to detect the end of each file, "eof()"
               will only detect the end of the last file.

[download]
Now, it's possible that eof in the previous line is used in a wrong way: 
close FH if eof;

[download]
but since the code fragment omits any other use of FH, it's hard to say.

Abigail

In reply to Re: Code review by Abigail-II
in thread Code review by mhearse

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.